Messages in this thread | | | Date | Fri, 07 Aug 2009 14:14:47 -0600 | From | Andreas Dilger <> | Subject | Re: [PATCH 3/4] vfs: change sb->s_maxbytes to a loff_t |
| |
On Aug 07, 2009 14:57 -0400, Jeff Layton wrote: > + /* > + * filesystems should never set s_maxbytes larger than MAX_LFS_FILESIZE > + * but s_maxbytes was an unsigned long long for many releases. Throw > + * this warning for a little while to try and catch filesystems that > + * violate this rule. This warning can be removed in 2.6.34. > + */ > + WARN(((unsigned long long) mnt->mnt_sb->s_maxbytes > MAX_LFS_FILESIZE), > + "WARNING: %s sets sb->s_maxbytes too large (%llu)", type->name, > + (unsigned long long) mnt->mnt_sb->s_maxbytes);
Rather than removing this check, it should be changed into a BUG_ON() so that no filesystems are added/modified to get it wrong. We hit this problem once in the past also...
Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.
| |