lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [ARM] Kirkwood: Marvell OpenRD-Base board support added to v2.6.31-rc5

    [ arm-linux mailing list added to CC ]

    On Thu, 6 Aug 2009, Dhaval Vasa wrote:

    > reference:
    > http://open-rd.org
    > http://code.google.com/p/openrd
    >
    > This patch is tested for:
    > 1. Boot from DRAM/NAND flash
    > 2. NAND read/write/erase
    > 3. GbE0
    > 4. USB read/write
    >
    > FIXME:
    > 1. SD/UART1 selection
    > 2. MPP configuration (currently, default)
    > 3. PEX
    >
    > Signed-off-by: Dhaval Vasa <dhaval.vasa@einfochips.com>

    Comments below.

    > diff --git a/arch/arm/mach-kirkwood/openrd_base-setup.c b/arch/arm/mach-kirkwood/openrd_base-setup.c
    > new file mode 100644
    > index 0000000..26b6e58
    > --- /dev/null
    > +++ b/arch/arm/mach-kirkwood/openrd_base-setup.c
    > @@ -0,0 +1,79 @@
    > +/*
    > + * arch/arm/mach-kirkwood/openrd_base-setup.c
    > + *
    > + * Marvell OpenRD Base Board Setup
    > + *
    > + * This file is licensed under the terms of the GNU General Public
    > + * License version 2. This program is licensed "as is" without any
    > + * warranty of any kind, whether express or implied.
    > + */
    > +
    > +#include <linux/kernel.h>
    > +#include <linux/init.h>
    > +#include <linux/platform_device.h>
    > +#include <linux/mtd/partitions.h>
    > +#include <linux/mv643xx_eth.h>
    > +#include <linux/gpio.h>
    > +#include <linux/leds.h>
    > +#include <asm/mach-types.h>
    > +#include <asm/mach/arch.h>
    > +#include <mach/kirkwood.h>
    > +#include <plat/mvsdio.h>
    > +#include "common.h"
    > +#include "mpp.h"

    The leds.h include appears to be unneeded.

    > +
    > +static struct mtd_partition openrd_base_nand_parts[] = {
    > + {
    > + .name = "u-boot",
    > + .offset = 0,
    > + .size = SZ_1M
    > + }, {
    > + .name = "uImage",
    > + .offset = MTDPART_OFS_NXTBLK,
    > + .size = SZ_4M
    > + }, {
    > + .name = "root",
    > + .offset = MTDPART_OFS_NXTBLK,
    > + .size = MTDPART_SIZ_FULL
    > + },
    > +};
    > +
    > +static struct mv643xx_eth_platform_data openrd_base_ge00_data = {
    > + .phy_addr = MV643XX_ETH_PHY_ADDR(8),
    > +};
    > +
    > +static struct mvsdio_platform_data openrd_base_mvsdio_data = {
    > + .gpio_card_detect = MPP29_GPIO, /* MPP29 used as SD card detect */
    > +};

    You should use a literal number here, like .gpio_card_detect = 29.

    > +static unsigned int openrd_base_mpp_config[] __initdata = {
    > + 0
    > +};

    Here belongs the MPP29_GPIO.


    Nicolas


    \
     
     \ /
      Last update: 2009-08-07 18:01    [W:0.027 / U:30.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site