lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH update x2] PM: Introduce core framework for run-time PM of I/O devices (rev. 13)
On Thu, 6 Aug 2009, Rafael J. Wysocki wrote:

> Hi,
>
> The patch below should address all of your most recent comments.

Only two comments.


> +static int __pm_request_idle(struct device *dev)
> +{
...
> + if (dev->power.request_pending) {
> + /* Any requests other then RPM_REQ_IDLE take precedence. */
> + if (dev->power.request != RPM_REQ_NONE)

Replace != with ==.

> + dev->power.request = RPM_REQ_IDLE;
> + else if (dev->power.request != RPM_REQ_IDLE)
> + retval = -EAGAIN;
> + return retval;


> --- linux-2.6.orig/drivers/base/dd.c
> +++ linux-2.6/drivers/base/dd.c
...
> @@ -306,6 +317,8 @@ static void __device_release_driver(stru
>
> drv = dev->driver;
> if (drv) {
> + pm_runtime_disable(dev);
> +
> driver_sysfs_remove(dev);
>
> if (dev->bus)
> @@ -324,6 +337,8 @@ static void __device_release_driver(stru
> blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
> BUS_NOTIFY_UNBOUND_DRIVER,
> dev);
> +
> + pm_runtime_enable(dev);
> }
> }

We may need to be more careful here. The driver's remove method may
want to do some runtime PM stuff to the device before giving up
control. On the other hand I'm not sure what _should_ be done here, so
I can't suggest anything better.

Alan Stern



\
 
 \ /
  Last update: 2009-08-07 17:45    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site