[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] pm_qos: remove BKL
    On Fri, 7 Aug 2009 07:54:13 +0200
    Frederic Weisbecker <> wrote:

    > May be the last doubt could be the blocking_notifier_call_chain() call from
    > update_target(). Not sure if these notifier handlers can expect to be called
    > concurrently?

    I will confess that I hadn't audited the notifiers. One could easily
    argue that concurrent calls to update_target() are entirely possible
    with the current code (only one of the callers had BKL protection),
    but, then, I'm supposed to be trying to make things better.

    The notifier call chain is already protected against concurrent
    modification, but, since an rwsem is used, concurrent calls to the
    notifiers themselves are possible. A quick grep shows that, in 2.6.31-rc5,
    there is exactly one notifier registered. It's in
    drivers/cpuidle/cpuidle.c; here's the whole thing:

    static void smp_callback(void *v)
    /* we already woke the CPU up, nothing more to do */

    After deep meditation on possible race condition scenarios, I am force to
    conclude that this particular notifier already has all of the protection it
    needs, and that any extra locking is likely to be superfluous.

    Thanks for looking at the patch,


     \ /
      Last update: 2009-08-07 17:15    [W:0.019 / U:2.828 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site