Messages in this thread | | | Date | Thu, 6 Aug 2009 17:27:48 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev |
| |
On Thu, Aug 06, 2009 at 02:19:23AM +0200, Kay Sievers wrote: > On Thu, Aug 6, 2009 at 02:06, Greg KH<greg@kroah.com> wrote: > > On Wed, Aug 05, 2009 at 09:55:49PM +0100, Alan Jenkins wrote: > > >> > + err = vfs_mkdir(nd.path.dentry->d_inode, > >> > + dentry, 0775); > >> > >> Is there a typo here? I think the mode should be 0755. 0755 is used > >> below, and that does fit better with the 0600 mode for device nodes. > > > > Yeah, I think you are correct. Kay, any objection to me making this > > change? > > No, sure no objection. It sounds right to use 0755. > I was just waiting if more things to fix come up. :)
I've made this fix in the version in my tree now.
thanks,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |