lkml.org 
[lkml]   [2009]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] Dirty page tracking & on-the-fly memory mirroring
FromAndi Kleen <>
DateFri, 07 Aug 2009 01:06:01 +0200
Jim Paradis <jparadis@redhat.com> writes:

> +#ifdef CONFIG_TRACK_DIRTY_PAGES
> +
> +#if PAGETABLE_LEVELS <= 3
> +static inline unsigned pud_index(unsigned long address)
> +{
> + return 0;
> +}
> +#endif

Needing special code for different page table levels is a really bad
sign that it uses the wrong abstractions for page tables. It should be using
the standard page walk idioms or perhaps even walk_page_range() now

-Andi


--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2009-08-07 01:09    [from the cache]
©2003-2010