[lkml]   [2009]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [Socketcan-users] [PATCH] CAN: make checking in can_rcv less restrictive
    Hi Oliver (again ;-)),

    On Thu, Aug 06, 2009 at 10:17:40PM +0200, Luotao Fu wrote:
    > Hi Oliver,
    > On Thu, Aug 06, 2009 at 06:48:23PM +0200, Oliver Hartkopp wrote:
    > >
    > > When this BUG() triggers, someone provided a definitely broken *CAN* network
    > > driver, and this needsfp to be fixed on that level.
    > In our case a sender (a FPGA) generates correct can frames carrying
    > wrong dlc length. This way the can driver on our side runs into the bug
    > though the driver itself is allright. The opposite needed to be fixed,
    > not our side. Though we do suffer a system crash only because the
    > sender sends trash into the can network. This is imo quite bad.

    /me answering myself
    had a closer look again. Seemed you are right. The can driver should
    have get the can_dlc right prior to passing the message a level higher.

    Pengutronix e.K. | Dipl.-Ing. Luotao Fu |
    Industrial Linux Solutions | |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2009-08-06 23:05    [W:0.021 / U:4.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site