lkml.org 
[lkml]   [2009]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] CAN: make checking in can_rcv less restrictive
    Date
    From: Michael Olbrich <m.olbrich@pengutronix.de>

    Checking for can frame format in can_rcv() is too restrictive. BUG_ON is way too
    heavy for the case that the can interface probably received a can frame with
    malicious format. Further it can be used for DDOS attack since BUG_ON can lead
    to kernel panic. Hence we turn this to WARN_ON instead.

    Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
    Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
    ---
    net/can/af_can.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/net/can/af_can.c b/net/can/af_can.c
    index e733725..e6dcf4b 100644
    --- a/net/can/af_can.c
    +++ b/net/can/af_can.c
    @@ -656,7 +656,7 @@ static int can_rcv(struct sk_buff *skb, struct net_device *dev,
    return 0;
    }

    - BUG_ON(skb->len != sizeof(struct can_frame) || cf->can_dlc > 8);
    + WARN_ON(skb->len != sizeof(struct can_frame) || cf->can_dlc > 8);

    /* update statistics */
    can_stats.rx_frames++;
    --
    1.6.3.3


    \
     
     \ /
      Last update: 2009-08-06 17:27    [W:0.067 / U:0.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site