Messages in this thread | | | Date | Thu, 06 Aug 2009 14:25:19 +0200 | From | Brice Goglin <> | Subject | Re: [PATCH 0/5 v4] x86: Adapt CPU topology detection for AMD Magny-Cours |
| |
Andreas Herrmann wrote: > Of course I thought also to implement it this way because it looks > more consistent, but IMHO the patches are less intrusive if this > scheme is _not_ used. Instead I kept core_siblings as is ("for > historic reasons", nobody needs to accustom to new semantics). And use > cpu_node_siblings where it really matters. >
Well, core_siblings and cpu_node_sibling will only be different on Magny-Cours anyway. So even if core_siblings becomes "all cores in cpu_node" instead of "all cores in socket", it won't actually break any existing setup. I personally prefer having the same kind of semantics for all foo_siblings rather than having something with a different meaning between core and thread.
Brice
| |