[lkml]   [2009]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 6/6] Makes procs file writable to move all threads by tgid at once
    On Thu, Aug 6, 2009 at 2:58 AM, Louis Rilling<> wrote:
    > mutex_lock_nested is not enough, since this would require putting each thread's
    > mutex in a different class. Again, something like mutex_lock_nest_lock() is
    > the solution, especially since Peter's recent improvement.

    OK, well if lockdep can't currently handle the "writer takes a lock on
    every thread" model, then maybe we should go with a simpler model
    until someone shows a performance issue with it? Ben's original
    patches had a per-task_struct lock, and a thread forking with CLONE_VM
    would down_read() its group leader's lock. Something that's even
    simpler (doesn't have to deal with thread group leader changing due to
    an execve()), and avoids the per-task_struct overhead would be to put
    the lock in sighand_struct instead (so only one per process). The
    procs file writer does a down_write(&tsk->sighand->fork_sem), and
    cgroup_fork() can do a down_read(&current->sighand->fork_sem) if

    If you put it as the second member of sighand_struct, there wouldn't
    even be any extra cacheline bouncing in the common case, since
    copy_sighand() would already have brought that line into cache in
    order to do atomic_inc(&current->sighand->count)


     \ /
      Last update: 2009-08-06 12:31    [W:0.028 / U:2.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site