lkml.org 
[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/3] ftrace: add tracepoint for timer


Anton Blanchard wrote:
> Hi,
>
>> Example ftrace output:
>> insmod-1712 [000] 145.901459: timer_init: timer=d0ace4b4
>> insmod-1712 [000] 145.901469: timer_start: timer=d0ace4b4 func=timer_fun expires=4294813629 timeout=199
>> <idle>-0 [000] 146.100230: timer_cancel: timer=d0ace4b4
>> <idle>-0 [000] 146.100233: timer_expire: timer=d0ace4b4 jiffies=4294813629
>> <idle>-0 [000] 146.100627: timer_callback_done: func=d0ace4b4
>
> Sorry I haven't followed the thread, but I was wondering why you changed
> the name of the entry and exit tracepoints (ie timer_entry/timer_exit).
>
> I think consistent naming is important to match the other static
> tracepoints, such as softirq_entry/softirq_exit, irq_entry/irq_exit and
> tasklet_entry/tasklet_exit.
>

I rename timer_entry/timer_exit to timer_expire/timer_callback_done just to
match this series:

*_init() -> *_start() -> *_expire()...

It's a complete timer's lifecycle.

Thanks,
Xiao

> Anton
>
>


\
 
 \ /
  Last update: 2009-08-06 05:25    [W:0.066 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site