lkml.org 
[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev
On Wed, Aug 05, 2009 at 06:43:02PM +0100, David Vrabel wrote:
> Greg KH wrote:
> >
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -929,6 +929,8 @@ int device_add(struct device *dev)
> > error = device_create_sys_dev_entry(dev);
> > if (error)
> > goto devtattrError;
> > +
> > + devtmpfs_create_node(dev);
> > }
> >
> > error = device_add_class_symlinks(dev);
> [...]
> > --- /dev/null
> > +++ b/drivers/base/devtmpfs.c
> [...]
> > +int devtmpfs_create_node(struct device *dev)
>
> Returns an int that's never checked. Is this intentional?
>
> > +int devtmpfs_delete_node(struct device *dev)
>
> Similarly.

Probably not, Kay, care to respin this?

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-08-05 19:59    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site