Messages in this thread | | | Date | Wed, 05 Aug 2009 13:20:21 -0400 | From | Rik van Riel <> | Subject | Re: [RFC] respect the referenced bit of KVM guest pages? |
| |
Andrea Arcangeli wrote: > On Wed, Aug 05, 2009 at 10:40:58AM +0800, Wu Fengguang wrote: >> */ >> - if ((vm_flags & VM_EXEC) && !PageAnon(page)) { >> + if ((vm_flags & VM_EXEC) || PageAnon(page)) { >> list_add(&page->lru, &l_active); >> continue; >> } >> > > Please nuke the whole check and do an unconditional list_add; > continue; there.
That would reinstate the bug that the VM has no pages available for evicting. There are very good reasons that only VM_EXEC file pages get moved to the back of the active list if they were referenced, and nothing else.
-- All rights reversed.
| |