lkml.org 
[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] respect the referenced bit of KVM guest pages?
Andrea Arcangeli wrote:
> On Wed, Aug 05, 2009 at 10:40:58AM +0800, Wu Fengguang wrote:
>> */
>> - if ((vm_flags & VM_EXEC) && !PageAnon(page)) {
>> + if ((vm_flags & VM_EXEC) || PageAnon(page)) {
>> list_add(&page->lru, &l_active);
>> continue;
>> }
>>
>
> Please nuke the whole check and do an unconditional list_add;
> continue; there.

That would reinstate the bug that the VM has no pages
available for evicting. There are very good reasons
that only VM_EXEC file pages get moved to the back of
the active list if they were referenced, and nothing
else.

--
All rights reversed.


\
 
 \ /
  Last update: 2009-08-05 19:23    [W:0.381 / U:1.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site