lkml.org 
[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Please revert fc4c73554c9d93b3e495f2f7acae1323b0d5db84. Re: [PATCH 1/2] ftrace: Fix the conditional that updates $ref_func

On Wed, 5 Aug 2009, Dave Airlie wrote:

> On Fri, Jul 24, 2009 at 2:16 AM, Matt Fleming<matt@console-pimps.org> wrote:
> > Fix the conditional that checks if we already have a $ref_func and that
> > the new function is weak. The code as previously checking whether either
> > condition was false, and we really need to only update $ref_func is both
> > cconditions are false.
> >
>
> This breaks the powerpc build on Fedora.
>
> When building on ppc64 this commit causes the links of drivers/hwmon/lm93.o
> to fail.
>
> It introduces an undefined symbol
> U .LM93_IN_FROM_REG
>
> that isn't produced when this patch is reverted
>
> This was found when the Fedora kernel failed to build when I pulled in
> -rc5-git3.
>
> can be seen at the end of:
> http://koji.fedoraproject.org/koji/getfile?taskID=1582002&name=build.log
>
> So can we revert this (at this stage in -rc5 or maybe fix it).

I'll boot up my PPC64 box and see if I can reproduce. In the mean time,
could you send me your config (privately)

Thanks,

-- Steve


\
 
 \ /
  Last update: 2009-08-05 15:33    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site