[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Please revert fc4c73554c9d93b3e495f2f7acae1323b0d5db84. Re: [PATCH 1/2] ftrace: Fix the conditional that updates $ref_func

On Wed, 5 Aug 2009, Dave Airlie wrote:

> On Fri, Jul 24, 2009 at 2:16 AM, Matt Fleming<> wrote:
> > Fix the conditional that checks if we already have a $ref_func and that
> > the new function is weak. The code as previously checking whether either
> > condition was false, and we really need to only update $ref_func is both
> > cconditions are false.
> >
> This breaks the powerpc build on Fedora.
> When building on ppc64 this commit causes the links of drivers/hwmon/lm93.o
> to fail.
> It introduces an undefined symbol
> that isn't produced when this patch is reverted
> This was found when the Fedora kernel failed to build when I pulled in
> -rc5-git3.
> can be seen at the end of:
> So can we revert this (at this stage in -rc5 or maybe fix it).

I'll boot up my PPC64 box and see if I can reproduce. In the mean time,
could you send me your config (privately)


-- Steve

 \ /
  Last update: 2009-08-05 15:33    [W:0.077 / U:4.304 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site