Messages in this thread | | | Date | Mon, 3 Aug 2009 18:55:20 -0700 | Subject | Re: [PATCH 6/6] Makes procs file writable to move all threads by tgid at once | From | Paul Menage <> |
| |
On Mon, Aug 3, 2009 at 6:45 PM, Li Zefan<lizf@cn.fujitsu.com> wrote: > > No. Note task exiting is not protected by cgroup_lock, so this can > happen: > > | cgroup_attach_task() > | oldcg = tsk->cgroups; > | (tasks->flags & TASK_EXISING == 0) > | rcu_assign_pointer(tsk->cgroups, newcg); > cgroup_exit() | > oldcg = tsk->cgroups; | > put_css_set_taskexit(oldcg); | > (now ref of olcg is 0) | > | put_css_set(oldcg); >
But in both cases, reading tsk->cgroups occurs with task->alloc_lock held.
Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |