lkml.org 
[lkml]   [2009]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ibmvscsi: avoid unnecessary use of kzalloc_pool
    Acked-by: Brian King <brking@linux.vnet.ibm.com>

    Sage Weil wrote:
    > The allocated struct is manually zeroed after allocation, so avoid using
    > the (broken) kzalloc mempool (which does not re-zero previously used items
    > when they are returned to the pool).
    >
    > CC: linux-scsi@vger.kernel.org
    > CC: James Bottomley <James.Bottomley@HansenPartnership.com>
    > Signed-off-by: Sage Weil <sage@newdream.net>
    > ---
    > drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
    > index 166d964..bb2c696 100644
    > --- a/drivers/scsi/ibmvscsi/ibmvfc.c
    > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
    > @@ -4217,7 +4217,7 @@ static int ibmvfc_alloc_mem(struct ibmvfc_host *vhost)
    > if (!vhost->trace)
    > goto free_disc_buffer;
    >
    > - vhost->tgt_pool = mempool_create_kzalloc_pool(IBMVFC_TGT_MEMPOOL_SZ,
    > + vhost->tgt_pool = mempool_create_kmalloc_pool(IBMVFC_TGT_MEMPOOL_SZ,
    > sizeof(struct ibmvfc_target));
    >
    > if (!vhost->tgt_pool) {


    --
    Brian King
    Linux on Power Virtualization
    IBM Linux Technology Center




    \
     
     \ /
      Last update: 2009-08-03 23:23    [W:0.024 / U:0.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site