lkml.org 
[lkml]   [2009]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] net: Add vbus_enet driver
On Mon, 03 Aug 2009 16:10:37 -0400
Gregory Haskins <ghaskins@novell.com> wrote:

> Stephen Hemminger wrote:
> > On Mon, 03 Aug 2009 13:18:02 -0400
> > Gregory Haskins <ghaskins@novell.com> wrote:
> >
> >> +
> >> +static const struct net_device_ops vbus_enet_netdev_ops = {
> >> + .ndo_open = vbus_enet_open,
> >> + .ndo_stop = vbus_enet_stop,
> >> + .ndo_set_config = vbus_enet_config,
> >> + .ndo_start_xmit = vbus_enet_tx_start,
> >> + .ndo_change_mtu = vbus_enet_change_mtu,
> >> + .ndo_tx_timeout = vbus_enet_timeout,
> >> +};
> >
> >
> > Missing
> > .ndo_set_mac_address = eth_mac_addr,
> > .ndo_validate_addr = eth_validate_addr,
> >
>
> Ack.
>
> > Also, should have change_mtu.
>
> note that I do have .ndo_change_mtu. I assume this is what you are
> referring to and just missed it. If there is something else I need
> there, let me know.

If you don't have a change_mtu, then MTU is unlimited. Can the device
handle 64K or larger transfers?


\
 
 \ /
  Last update: 2009-08-03 22:21    [W:0.061 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site