| Date | Mon, 3 Aug 2009 11:30:30 -0700 | From | Stephen Hemminger <> | Subject | Re: [PATCH 6/7] net: Add vbus_enet driver |
| |
On Mon, 03 Aug 2009 13:18:02 -0400 Gregory Haskins <ghaskins@novell.com> wrote:
> + > +static const struct net_device_ops vbus_enet_netdev_ops = { > + .ndo_open = vbus_enet_open, > + .ndo_stop = vbus_enet_stop, > + .ndo_set_config = vbus_enet_config, > + .ndo_start_xmit = vbus_enet_tx_start, > + .ndo_change_mtu = vbus_enet_change_mtu, > + .ndo_tx_timeout = vbus_enet_timeout, > +};
Missing .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
Also, should have change_mtu.
Suggest adding ethtool to report link and settings.
For performance this device should do scatter/gather, tso, gso, etc.
|