lkml.org 
[lkml]   [2009]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3
>> >It is recommended to separate definition,
>> >and assignment.
>> >So this should look like this:
>> > struct memrar_allocator *allocator;
>> > allocator = 0;
>> Okay, I'll fix that, too. Should this go into Documentation/CodingStyle,
>too?
>
>I don't agree with that at all, neither does a lot of the kernel source.
>
>Automatic structs with initializers:
>$ grep -rP --include=*.c "^\s+struct\s+\w+\s*\*\s*\w+\s*=\s*\w+\s*;" * | wc
>-l
>9498
>
>I think it should be struct memrar_allocator *allocator = NULL;

Got it. I've already started changing all zero pointer initializations to NULL instead. I'll also leave the declaration and initialization on the same line for now.

Thanks again!
-Ossama


\
 
 \ /
  Last update: 2009-08-03 19:55    [from the cache]
©2003-2011 Jasper Spaans