lkml.org 
[lkml]   [2009]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3
Hi Joe,

>On Sat, 2009-08-01 at 09:30 +0200, Sam Ravnborg wrote:
>> Try to avoid breaking your printable line.
>> It is much easier to grep for the line when it is on a single
>> line.
>> If you violate the 80 chars per line rule do to this then accept
>> that grepable lines is better than keeping them 80 or less wide.
>
>Maybe it's better to ignore the indent guideline here as well.
>An outdent might be preferable to having the line exceed 80 chars.
>
>Maybe:
> WARN(capacity < block_size * 2,
> "Memory allocator is only large enough to hold one block.\n");
>or
> WARN(capacity < block_size * 2,
>"Memory allocator is only large enough to hold one block.\n");

Okay, I'll see what I can do improve the readability and grep-ability of these log messages.

>Any format string longer than 80 chars is likely a poor log entry.

Agreed!

Thanks Joe!
-Ossama


\
 
 \ /
  Last update: 2009-08-03 19:39    [W:0.384 / U:0.212 seconds]
©2003-2011 Jasper Spaans. Advertise on this site