lkml.org 
[lkml]   [2009]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateMon, 3 Aug 2009 18:33:04 +0200
FromAlbin Tonnerre <>
SubjectRe: [PATCH V2] au1xmmc: dev_pm_ops conversion
On Sat, Jul 25, 2009, Frans Pop wrote:
> Yes, I see that in drivers/base/platform.c (legacy) .suspend resp. .resume
> also got called for those cases?
> Ouch :-(

This really looks like it's error-prone (I made this mistake for atmel_serial
and wouldn't have noticed if Frans hadn't told me), and AFAICS, for a number of
drivers we'll have suspend = freeze = poweroff and resume = thaw = restore.
Maybe putting something like this in pm.h would help ?

#define PM_OPS(name, suspend, resume) \
struct dev_pm_ops name = { \
.suspend = suspend, \
.resume = resume, \
.freeze = suspend, \
.thaw = resume, \
.poweroff = suspend, \
.restore = resume, \
};
Cheers,
--
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com


\
 
 \ /
  Last update: 2009-08-03 18:35    [from the cache]
©2003-2010