Messages in this thread |  | | | Date | Mon, 3 Aug 2009 18:33:04 +0200 | | From | Albin Tonnerre <> | | Subject | Re: [PATCH V2] au1xmmc: dev_pm_ops conversion |
| |
On Sat, Jul 25, 2009, Frans Pop wrote: > Yes, I see that in drivers/base/platform.c (legacy) .suspend resp. .resume > also got called for those cases? > Ouch :-(
This really looks like it's error-prone (I made this mistake for atmel_serial and wouldn't have noticed if Frans hadn't told me), and AFAICS, for a number of drivers we'll have suspend = freeze = poweroff and resume = thaw = restore. Maybe putting something like this in pm.h would help ?
#define PM_OPS(name, suspend, resume) \ struct dev_pm_ops name = { \ .suspend = suspend, \ .resume = resume, \ .freeze = suspend, \ .thaw = resume, \ .poweroff = suspend, \ .restore = resume, \ }; Cheers, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
|  |