lkml.org 
[lkml]   [2009]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] kmemleak: Inform kmemleak about kernel stack allocation

* Catalin Marinas <catalin.marinas@arm.com> wrote:

> Traversing all the tasks in the system for scanning the kernel
> stacks requires locking which increases the kernel latency
> considerably. This patch informs kmemleak about newly allocated or
> freed stacks so that they are treated as any other allocated
> object. Subsequent patch will remove the explicit stack scanning
> from mm/kmemleak.c.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> ---
> arch/x86/include/asm/thread_info.h | 7 ++++++-
> arch/x86/kernel/process.c | 2 ++
> kernel/fork.c | 7 ++++++-
> 3 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> index fad7d40..f26432a 100644
> --- a/arch/x86/include/asm/thread_info.h
> +++ b/arch/x86/include/asm/thread_info.h
> @@ -162,7 +162,12 @@ struct thread_info {
> #define __HAVE_ARCH_THREAD_INFO_ALLOCATOR
>
> #define alloc_thread_info(tsk) \
> - ((struct thread_info *)__get_free_pages(THREAD_FLAGS, THREAD_ORDER))
> +({ \
> + struct thread_info *ti = (struct thread_info *) \
> + __get_free_pages(THREAD_FLAGS, THREAD_ORDER); \
> + kmemleak_alloc(ti, THREAD_SIZE, 1, THREAD_FLAGS); \
> + ti; \
> +})

Sidenote:this used to be a trivial wrapper to gfp so it was
borderline OK as a CPP macro - now it's a non-trivial CPP wrapper
macro which is not OK. Mind converting it to an inline function?

Ingo


\
 
 \ /
  Last update: 2009-08-29 15:33    [W:0.077 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site