lkml.org 
[lkml]   [2009]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[RFC] [PATCH 0/1] hrtimers: Remove unnecessary clock events device programming

hrtimer_force_reprogram() was being called quite often unnecessarily.
The following patch caches the hrtimer that causes the
cpu_base->expires_next value to change. This way, we force the reprogram
only when remove_hrtimer() finds that its going to remove an hrtimer
which was about expire next. IOW, we forgo reprogramming the clock
events device, if the current timer to be removed isn't at the root of
the expires tree.

Also removed the hrtimer_is_queued check from remove_hrtimer and made
appropriate changes to all callers. That check seemed redundant.


Results:

Shows ~60% reduction in the following calls to program clock events device.
- tick_nohz_restart_sched_tick (tick_sched_timer)
- hrtimer_start (tick_sched_timer)

I haven't traced all the callers yet, this was from a hack to
timer_stats. If you guys have a better way to test this, I'll give that
a go.

Tested on v2.6.29 on an ARM based embedded device.

Cheers,
Ashwin


\
 
 \ /
  Last update: 2009-08-27 23:51    [W:0.088 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site