Messages in this thread | | | Date | Wed, 26 Aug 2009 23:30:24 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH] r8169: Reduce looping in the interrupt handler. |
| |
Eric W. Biederman <ebiederm@xmission.com> : [...] > It is a bit weird but it also means we aren't playing silly games > with status inside the loop. So if we go through the loop we ack > everything in status.
I fear we have some longstanding problem anyway :
1. quiescent state 2. packets are received 3. rtl8169_interrupt schedules napi, clears IntrStatus and exits 4. packets are received and some non-napi event happens 5. rtl8169_interrupt wakes up, reads IntrStatus and goes on... 6. rtl8169_poll wakes up, processes Rx and Tx napi events and goes on... 7. tp->intr_mask still equals ~tp->napi_event : rtl8169_interrupt handler does not even try to schedule napi. 8. more packets are received 9. rtl8169_interrupt clears IntrStatus a. rtl8169_poll reenables napi scheduling, updates IntrMask and exits b. rtl8169_interrupt reads a perfectly clean IntrStatus and exits
-- Ueimor
| |