lkml.org 
[lkml]   [2009]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 2/2] vhost_net: a kernel-level virtio server
On Tue, Aug 25, 2009 at 04:16:34PM +0300, Michael S. Tsirkin wrote:
> > > + /* If they don't want an interrupt, don't send one, unless empty. */
> > > + if ((flags & VRING_AVAIL_F_NO_INTERRUPT) && vq->inflight)
> > > + return;
> >
> > And I wouldn't support notify on empty at all, TBH.
>
> If I don't, virtio net in guest uses a timer, which might be expensive.
> Will need to check what this does.
>
> > It should
> > definitely be conditional on the guest accepting the NOTIFY_ON_EMPTY
> > feature.

lguest does not do it this way though, do it?


\
 
 \ /
  Last update: 2009-08-26 19:03    [W:0.068 / U:0.128 seconds]
©2003-2014 Jasper Spaans. Advertise on this site