Messages in this thread | | | Date | Tue, 25 Aug 2009 09:58:16 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] trace_events: fix napi's tracepoint |
| |
* Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote:
> Currently, the napi's tracepoint works will is depend on > "DECLARE_TRACE" definiens in include/trace/define_trace.h, > like below: > > #include <trace/events/skb.h> // include define_trace.h > #include <trace/events/napi.h> > > there have error, if we remove "#include <trace/events/skb.h>" > or include napi.h in the front of include skb.h, It should > depend on the definiens in include/linux/tracepoint.h and we > can remove the "DECLARE_TRACE" definiens in > include/trace/define_trace.h, because "TRACE_EVENT" not use it > > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > --- > include/trace/define_trace.h | 4 ---- > net/core/net-traces.c | 4 +++- > 2 files changed, 3 insertions(+), 5 deletions(-)
This will collide with tracing bits in the networking tree. The skb-tracing plugin there should be turned into proper TRACE_EVENT() tracepoints.
Neil was away for some time but i think soon we should see some movement here.
Ingo
| |