Messages in this thread | | | Date | Tue, 25 Aug 2009 15:35:42 +0100 | From | "Jan Beulich" <> | Subject | Re: [tip:x86/urgent] x86: Fix build with older binutilsandconsolidate linker script |
| |
>>> Ingo Molnar <mingo@elte.hu> 25.08.09 16:14 >>> > >* Jan Beulich <JBeulich@novell.com> wrote: > >> >>> Ingo Molnar <mingo@elte.hu> 25.08.09 15:56 >>> >> >Would it be possible to split it into two pieces: 'minimal fix' and >> >'clean up' portions? >> >> Besides being cumbersome, that would make it even larger, so I'd >> say that's not worth it. > >I mean the two patches yield the same end result. The first one
I also understood it that way.
>(which is smaller, hopefully) gets committed to x86/urgent, the >second one (the cleanups and other non-essentials) gets pushed >upstream in .32.
The cleanup part really isn't much more than what I described with "Once touching this code, also use the various data section helper macros from include/asm-generic/vmlinux.lds.h.", and if the first patch wouldn't use those macros, it would just grow and become even less readable.
Jan
| |