Messages in this thread Patch in this message | | | Subject | RE: [PATCH] : eliminate code duplication in kernel/tracepoint.c | Date | Tue, 25 Aug 2009 07:00:02 -0700 | From | "Anirban Sinha" <> |
| |
>> I still think it's better not to remove this break. every "case" >> should have a break or a return, expect for the falling throught >> cases. > >Correct. That might seem like a superfluous statement, but when we >add new cases it stays robust while with the missing break one can >create an unintended fall-through codepath. > > Ingo
Thanks a lot Li and Ingo for all the feedback. Final patch goes below:
From f9826874841a5b15b553cfb6540d1ecfa6b55531 Mon Sep 17 00:00:00 2001 From: Anirban Sinha <asinha@zeugmasystems.com> Date: Tue, 25 Aug 2009 06:50:54 -0700 Subject: cleanup: eliminate code duplication in kernel/tracepoint.c
Signed-off-by: Anirban Sinha <asinha@zeugmasystems.com> Reviewed-by: Li Zefan <lizf@cn.fujitsu.com> --- kernel/tracepoint.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 1ef5d3a..4840ab6 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -554,9 +554,6 @@ int tracepoint_module_notify(struct notifier_block *self, switch (val) { case MODULE_STATE_COMING: - tracepoint_update_probe_range(mod->tracepoints, - mod->tracepoints + mod->num_tracepoints); - break; case MODULE_STATE_GOING: tracepoint_update_probe_range(mod->tracepoints, mod->tracepoints + mod->num_tracepoints); -- 1.6.4
| |