lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch 5/8] ia64: implement crashkernel=auto

* Amerigo Wang <amwang@redhat.com> wrote:

> Ingo Molnar wrote:
>>
>> e) All the 'else' statements are superflous and make it all harder
>> to read.
>>
>> f) 2ULL<<30 should be written as 1ULL<31, to keep things consistent.
>>
>
> Hi,
>
> The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is
> exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)

i have no trouble reading 1ULL<<31 as 2G ;-) OTOH, the logic and
pattern of the comparisons (especially without the comment) looked
odd at first sight, until i noticed this.

Ingo


\
 
 \ /
  Last update: 2009-08-24 09:47    [W:0.090 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site