lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] scripts/ver_linux
    On Sun, Aug 23, 2009 at 08:52:05PM -0700, Christian Kujau wrote:
    >On Sun, 16 Aug 2009 at 22:54, Christian Kujau wrote:
    >> On Mon, 17 Aug 2009 at 13:47, Amerigo Wang wrote:
    >> > Hmm, so probably you are also using a Red Hat distribution?
    >> > AFAIK, only some Fedora and RHEL don't have /sbin and /usr/sbin in $PATH.
    >>
    >> No, Debian Linux - but as a mere user I never have sbin directories in my
    >> PATH. And since it is a headless system, I removed the console-* packages,
    >> that's why I did not have the "loadkeys" command installed. No big deal,
    >> but the ver_linux output looked weird....
    >
    >Hm, looking at the changelog of scripts/ver_linux again I see:
    >
    > > commit 48a61569bb5396415c5dad0e81e1cfeb87c0aca3
    > > Author: Adrian Bunk <bunk@kernel.org>
    > > Date: Wed Jul 23 22:50:45 2008 +0300
    > >
    > > kbuild: scripts/ver_linux: don't set PATH
    > >
    > > It would have saved both a bug submitter and me a few hours if
    > > scripts/ver_linux had picked the same gcc as the build.
    > >
    > > Since I can't see any reason why it fiddles with PATH at all this
    > > patch therefore removes the PATH setting.
    >
    >I'm still a bit confused, Amerigo, why you thought not having /sbin
    >directories in PATH was distribution specific - I don't recall any
    >distribution where mere users had /sbin:/usr/sbin in their PATH.


    Try archlinux.


    >I was tempted to specify the whole path in ver_linux, but that'll break
    >for sure.
    >
    >Adrian, what do you think - this patch puts the sbin paths *after*
    >PATH, so that should not lead to such conflicts your commit once fixed,
    >right?

    I believe so.


    \
     
     \ /
      Last update: 2009-08-24 06:19    [W:0.028 / U:155.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site