[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/3] inotify: do not BUG on idr entries at inotify destruction
    On Mon, 2009-08-24 at 12:23 -0700, Linus Torvalds wrote:
    > On Mon, 24 Aug 2009, Eric Paris wrote:
    > >
    > > You suspect correctly. :( I'll fix in my tree before I request a
    > > pull....
    > Can you change the WARN() to a WARN_ONCE() too.
    > Generally, we prefer the "ONCE" variant if there isn't some intrisic
    > reason why we'd want to know about each event. If there is some load that
    > triggers this, do you care about _how_many_times_ it happens, or about the
    > fact that it happens in the first place? In this case, I think it's the
    > "happens in the first place" case - once you see it a single time, the
    > rest of the reports aren't that interesting.
    > And using the ONCE thing means that we know it's not going to spam the
    > logs.


     \ /
      Last update: 2009-08-24 21:35    [W:0.021 / U:21.032 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site