lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 15/15] x86: Fix cpu_coregroup_mask to return correct cpumask on multi-node processors
    From
    Date
    On Thu, 2009-08-20 at 15:46 +0200, Andreas Herrmann wrote:
    > The correct mask that describes core-siblings of an processor
    > is topology_core_cpumask. See topology adapation patches, especially
    > http://marc.info/?l=linux-kernel&m=124964999608179


    argh, violence, murder kill.. this is the worst possible hack and you're
    extending it :/

    > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
    > ---
    > arch/x86/kernel/smpboot.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
    > index f797214..f39bb2c 100644
    > --- a/arch/x86/kernel/smpboot.c
    > +++ b/arch/x86/kernel/smpboot.c
    > @@ -446,7 +446,7 @@ const struct cpumask *cpu_coregroup_mask(int cpu)
    > * And for power savings, we return cpu_core_map
    > */
    > if (sched_mc_power_savings || sched_smt_power_savings)
    > - return cpu_core_mask(cpu);
    > + return topology_core_cpumask(cpu);
    > else
    > return c->llc_shared_map;
    > }


    \
     
     \ /
      Last update: 2009-08-24 17:39    [W:0.022 / U:32.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site