Messages in this thread | | | Date | Mon, 24 Aug 2009 14:58:06 +1000 (EST) | From | James Morris <> | Subject | Re: [PATCH 1/2] kernel_read: redefine offset type |
| |
On Fri, 21 Aug 2009, Mimi Zohar wrote:
> vfs_read() offset is defined as loff_t, but kernel_read() > offset is only defined as unsigned long. Redefine > kernel_read() offset as loff_t. > > Cc: stable@kernel.org > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
Reviewed-by: James Morris <jmorris@namei.org>
> --- > fs/exec.c | 4 ++-- > include/linux/fs.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/exec.c b/fs/exec.c > index 4a8849e..fb4f3cd 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -678,8 +678,8 @@ exit: > } > EXPORT_SYMBOL(open_exec); > > -int kernel_read(struct file *file, unsigned long offset, > - char *addr, unsigned long count) > +int kernel_read(struct file *file, loff_t offset, > + char *addr, unsigned long count) > { > mm_segment_t old_fs; > loff_t pos = offset; > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 67888a9..73e9b64 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2123,7 +2123,7 @@ extern struct file *do_filp_open(int dfd, const char *pathname, > int open_flag, int mode, int acc_mode); > extern int may_open(struct path *, int, int); > > -extern int kernel_read(struct file *, unsigned long, char *, unsigned long); > +extern int kernel_read(struct file *, loff_t, char *, unsigned long); > extern struct file * open_exec(const char *); > > /* fs/dcache.c -- generic fs support functions */ > -- > 1.6.0.6 >
-- James Morris <jmorris@namei.org>
| |