[lkml]   [2009]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [Patch 5/8] ia64: implement crashkernel=auto
    Ingo Molnar wrote:
    > e) All the 'else' statements are superflous and make it all harder
    > to read.
    > f) 2ULL<<30 should be written as 1ULL<31, to keep things consistent.


    The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is
    exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)

    > g) A nice comment explaining the purpose and logic wouldnt hurt.

    Yup, in fact patch 8/8 has the doc for this, but I will copy that here
    as a comment too.


     \ /
      Last update: 2009-08-24 04:07    [W:0.019 / U:13.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site