lkml.org 
[lkml]   [2009]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/1] aoe: ensure we initialise the request_queue correctly
Rafael, this matches regression bug #13942 "Troubles with AoE and
uninitialized object".

Will test and report how it works out here.

Bruno


On Fri, 21 August 2009 Andy Whitcroft <apw@canonical.com> wrote:
> We have been seeing oopses in very recent kernels when using the AOE
> driver. When attempting to mount remote devices we get a warning from
> the kobject layer:
>
> [ 2645.959090] kobject '<NULL>' (ffff880059ca22c0): tried to add
> an uninitialized object, something is seriously wrong.
>
> Looking at the driver it seems to have always had an embedded
> request_queue and it is this that is throwing the error. It appears
> the intent is tha these would be allocated and released using
> helpers, and the lack of these leaves the object uninitialised and
> throws the error. It is unclear how this could ever have worked.
> Anyhow the following email contains a patch to allocate and release
> this request_queue via the standard helpers. This has bene shown to
> fix the issue in testing.
>
> Comments.
>
> -apw
>
> Andy Whitcroft (1):
> aoe: ensure we initialise the request_queue correctly
>
> drivers/block/aoe/aoe.h | 2 +-
> drivers/block/aoe/aoeblk.c | 6 +++---
> drivers/block/aoe/aoedev.c | 11 ++++++++++-
> 3 files changed, 14 insertions(+), 5 deletions(-)


\
 
 \ /
  Last update: 2009-08-22 11:33    [from the cache]
©2003-2011 Jasper Spaans