Messages in this thread Patch in this message | | | Date | Fri, 21 Aug 2009 16:41:13 +0530 | From | Kamalesh Babulal <> | Subject | Re: [PATCH -next] block: blk-iopoll sysctl iff CONFIG_BLOCK |
| |
* Jens Axboe <jens.axboe@oracle.com> [2009-08-07 21:21:44]:
> On Fri, Aug 07 2009, Randy Dunlap wrote: > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > New block-iopoll sysctl should be surrounded by CONFIG_BLOCK to > > prevent build error: > > > > kernel/built-in.o:(.data+0x2990): undefined reference to `blk_iopoll_enabled' > > Thanks, I'll just kill off this sysctl, it should be driver controller > anyway. Was just easier for testing :-)
Hi Jens,
This build failure is still seen with next-20090820 kernel, removing the sysctl helps. Attaching the patch based on your recommendation. Please drop the patch if you already have in queue.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> -- kernel/sysctl.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 40f2d2c..6e67ec2 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -991,14 +991,6 @@ static struct ctl_table kern_table[] = { .proc_handler = &proc_dointvec, }, #endif - { - .ctl_name = CTL_UNNUMBERED, - .procname = "blk_iopoll", - .data = &blk_iopoll_enabled, - .maxlen = sizeof(int), - .mode = 0644, - .proc_handler = &proc_dointvec, - }, /* * NOTE: do not add new entries to this table unless you have read * Documentation/sysctl/ctl_unnumbered.txt
Kamalesh
| |