lkml.org 
[lkml]   [2009]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Samsung laptop driver
On Fri, 21 Aug 2009 15:59:25 -0700
Greg KH <greg@kroah.com> wrote:
> Jesse, I don't know how this is going to play with your recently added
> backlight support for the i915 driver. As you don't have control over
> the LEDs and other stuff that this driver is going to support, I think
> we need some way to keep the i915 driver from messing with the
> backlight values, don't you think?

Right, it should be fine. The i915 driver should only take control and
provide a backlight when:
- no ACPI method is available
- no platform method is available (like this one)
- backlight is exposed through the GPU or i2c

So I'm a lot happier now that you've figured out the proper platform
interface. :) The test code I sent out earlier didn't work for Mike
because his VBIOS (properly it turns out) indicated that there was an
external agent in charge of the backlight.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2009-08-22 01:23    [W:0.076 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site