lkml.org 
[lkml]   [2009]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: properly annotate alternatives.c
On Fri, Aug 21, 2009 at 10:09:08PM +0200, Ingo Molnar wrote:
>
> * Jan Beulich <JBeulich@novell.com> wrote:
>
> > Some of the NOPs tables aren't used on 64-bits, quite some code and
> > data is needed post-init for module loading only, and a couple of
> > functions aren't used outside that file (i.e. can be static, and don't
> > need to be exported).
> >
> > The change to __INITDATA/__INITRODATA is needed to avoid an assembler
> > warning.
> >
> > Signed-off-by: Jan Beulich <jbeulich@novell.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> >
> > ---
> > arch/x86/include/asm/alternative.h | 7 ----
> > arch/x86/kernel/alternative.c | 56 +++++++++++++++++++++----------------
> > include/linux/init.h | 12 ++++++-
> > 3 files changed, 42 insertions(+), 33 deletions(-)
>
> looks like a nice improvement. Sam, what do you think?
I briefly looked at the __INIT*DATA cahnges.
I recall that I had something similar only that I used @progbits which
arm does not support. And I did not want to specialcase arm.

It is only recently I learned that we can always use %progbits.

So it has my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Sam


\
 
 \ /
  Last update: 2009-08-21 23:57    [W:0.159 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site