Messages in this thread | | | Subject | Re: [PATCH,v2] Re: e1000e: why does pci_enable_pcie_error_reporting() fail on my hp2510p? | From | Jens Rosenboom <> | Date | Fri, 21 Aug 2009 09:06:12 +0200 |
| |
On Fri, 2009-08-21 at 08:48 +0200, Frans Pop wrote: [...] > @@ -5301,9 +5296,6 @@ static void __devexit e1000_remove(struct pci_dev *pdev) > > /* AER disable */ > err = pci_disable_pcie_error_reporting(pdev); > - if (err) > - dev_err(&pdev->dev, > - "pci_disable_pcie_error_reporting failed 0x%x\n", err); > > pci_disable_device(pdev); > }
While you're at it, why don't you also remove the "err =" here, which allows you to drop the variable from that function completely? This applies to all three *_remove() functions.
| |