[lkml]   [2009]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] bsdacct: switch credentials for writing to the accounting file
    Michal Schmidt <> wrote:

    > When process accounting is enabled, every exiting process writes a log
    > to the account file. In addition, every once in a while one of the
    > exiting processes checks whether there's enough free space for the log.
    > SELinux policy may or may not allow the exiting process to stat the fs.
    > So unsuspecting processes start generating AVC denials just because
    > someone enabled process accounting.
    > For these filesystem operations, the exiting process's credentials
    > should be temporarily switched to that of the process which enabled
    > accounting, because it's really that process who wanted to have the
    > accounting information logged.
    > Signed-off-by: Michal Schmidt <>

    Do you really need to keep creds in acct? Can you used acct->file->f_cred
    instead? Those are the credentials of the process that opened the file, so
    acct->cred may be redundant.

    Other than that, it looks reasonable.


     \ /
      Last update: 2009-08-20 12:05    [W:0.020 / U:3.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site