lkml.org 
[lkml]   [2009]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] Drop platform sysfs attributes from compal-laptop
From
On 8/19/09, Mario Limonciello <Mario_Limonciello@dell.com> wrote:
> Now that there is rfkill support, there is no need
> to manually grok the files in sysfs
> Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com>

> @@ -464,12 +314,7 @@ static int __init compal_init(void)
>
> ret = platform_device_add(compal_device);
> if (ret)
> - goto fail_platform_device1;
> -
> - ret = sysfs_create_group(&compal_device->dev.kobj,
> - &compal_attribute_group);
> - if (ret)
> - goto fail_platform_device2;
> + goto fail_platform_device;
>
> ret = setup_rfkill();
> if (ret)
> @@ -481,11 +326,7 @@ static int __init compal_init(void)
> return 0;
>
> fail_rfkill:
> -fail_platform_device2:
> -
> - platform_device_del(compal_device);

Don't you still need to call platform_device_del() for the fail_rfkill case?

> -
> -fail_platform_device1:
> +fail_platform_device:
>
> platform_device_put(compal_device);


\
 
 \ /
  Last update: 2009-08-20 11:19    [W:0.038 / U:2.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site