lkml.org 
[lkml]   [2009]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] eventfd: new EFD_STATE flag
On Thu, Aug 20, 2009 at 08:38:48PM +0300, Avi Kivity wrote:
> On 08/20/2009 07:20 PM, Davide Libenzi wrote:
>>
>> I briefly looked at this while in vacation, although I did not reply
>> hoping the horrible feeling about this code would go away.
>> It didn't.
>> I find this to be an ugly and ad-hoc multiplexing of eventfd with added
>> functionalities of questionable general use.
>> I'm pretty sure you can do better on KVM side, to solve the problem w/out
>> littering eventfd.
>>
>>
>
> While we could argue about this my feeling is that we should drop this,
> at least until we can quantify what benefit it has and whether there are
> any Davide-acceptable alternatives.
>
> In the meanwhile, we can let vhost-net support edge-triggered interrupts
> only, let qemu terminate those eventfds and convert then to
> level-triggered interrupts (which it can then inject using the existing
> ioctl). It will keep vhost-net and kvm simpler at the cost of some
> performance penalty to guests using level interrupts. These suck anyway
> so we'll point users at msi.

I thought the point was to move assigned devices out of KVM?

> --
> I have a truly marvellous patch that fixes the bug which thisb
> signature is too narrow to contain.


\
 
 \ /
  Last update: 2009-08-20 20:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site