Messages in this thread |  | | | Date | Thu, 20 Aug 2009 10:44:27 -0700 (PDT) | | From | Davide Libenzi <> | | Subject | Re: [PATCH 0/2] eventfd: new EFD_STATE flag |
| |
On Thu, 20 Aug 2009, Avi Kivity wrote:
> On 08/20/2009 07:20 PM, Davide Libenzi wrote: > > > > I briefly looked at this while in vacation, although I did not reply > > hoping the horrible feeling about this code would go away. > > It didn't. > > I find this to be an ugly and ad-hoc multiplexing of eventfd with added > > functionalities of questionable general use. > > I'm pretty sure you can do better on KVM side, to solve the problem w/out > > littering eventfd. > > > > > > While we could argue about this my feeling is that we should drop this, at > least until we can quantify what benefit it has and whether there are any > Davide-acceptable alternatives.
I really didn't mean to be harsh, but seriously, we cannot just have a Multiplexing Feast over eventfd, with one-time users.
- Davide
|  |