Messages in this thread | | | Date | Thu, 20 Aug 2009 14:04:36 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 02/17] vfs: Export __generic_file_aio_write() and add some comments |
| |
On Wed 19-08-09 12:11:45, Christoph Hellwig wrote: > On Wed, Aug 19, 2009 at 06:04:29PM +0200, Jan Kara wrote: > > Rename __generic_file_aio_write_nolock() to __generic_file_aio_write(), add > > comments to write helpers explaining how they should be used and export > > __generic_file_aio_write() since it will be used by some filesystems. > > The renaming and commenting looks good to me, and the export is fine > with me given that we'll actually use it later one. > > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Can we maybe get rid of generic_file_aio_write_nolock after you patch > series? In principle we could. It's just that block devices don't need i_mutex for serializing writes so I found it dumb to serialize writes to the block device needlessly. But we could move generic_file_aio_write_nolock to blockdev.c and name it like blockdev_aio_write() since noone else uses it after my series. I guess I'll do that.
Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |