lkml.org 
[lkml]   [2009]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 20/25] io-controller: map async requests to appropriate cgroup
Vivek Goyal wrote:
...
> +
> +struct io_group *io_get_io_group_bio(struct request_queue *q, struct bio *bio,
> + int create)
> +{
> + struct page *page = NULL;
> +
> + /*
> + * Determine the group from task context. Even calls from
> + * blk_get_request() which don't have any bio info will be mapped
> + * to the task's group
> + */
> + if (!bio)
> + goto sync;
> +
> + if (bio_barrier(bio)) {
> + /*
> + * Map barrier requests to root group. May be more special
> + * bio cases should come here
> + */
> + return q->elevator->efqd.root_group;
> + }
> +
> + /* Map the sync bio to the right group using task context */
> + if (elv_bio_sync(bio))
> + goto sync;
> +
> +#ifdef CONFIG_TRACK_ASYNC_CONTEXT
> + /* Determine the group from info stored in page */
> + page = bio_iovec_idx(bio, 0)->bv_page;
> + return io_get_io_group(q, page, create);
> +#endif
> +
> +sync:
> + return io_get_io_group(q, NULL, create);

Fix build warning.

block/elevator-fq.c: In function ‘io_get_io_group_bio’:
block/elevator-fq.c:2075: warning: unused variable ‘page’

---
diff --git a/block/elevator-fq.c b/block/elevator-fq.c
index 66b10eb..d304f79 100644
--- a/block/elevator-fq.c
+++ b/block/elevator-fq.c
@@ -2102,7 +2102,7 @@ struct io_group *io_get_io_group_bio(struct request_queue *q, struct bio *bio,
#endif

sync:
- return io_get_io_group(q, NULL, create);
+ return io_get_io_group(q, page, create);
}
EXPORT_SYMBOL(io_get_io_group_bio);

> +}
> +EXPORT_SYMBOL(io_get_io_group_bio);
> +


--
Regards
Gui Jianfeng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-08-03 04:17    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site