Messages in this thread | | | Date | Wed, 19 Aug 2009 10:50:29 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] splice: update mtime and atime on files |
| |
On Tue, Aug 18 2009, Miklos Szeredi wrote: > On Tue, 18 Aug 2009, Jens Axboe wrote: > > I've never heard anyone complain about this, and I suspect that Miklos > > found it from code inspection rather than experiencing an issue with it. > > Right, I found it by code inspection. > > > So while it can indeed be classified as a bug (and it is), the impact is > > not huge. > > > > That said, I don't have a huge issue with shoving this in -stable. I > > just don't think it's a big deal. > > I agree that it's not a huge issue, however it might be worth it to > add it to -stable for the sake of distro kernels which are usually > based on the long term stable branch. If new apps start to use the > splice interface then we want those to work well on distros as well as > the latest kernel.org kernels.
As I said, I don't have a problem with adding it to -stable, even if it isn't a critical issue. The patch is straight forward and fixes a real issue, so risk is low (and benefit high).
-- Jens Axboe
| |