Messages in this thread | | | Date | Wed, 19 Aug 2009 19:41:41 -0700 | Subject | Re: [PATCH 1/8] Revert commit 8827c288feb7810185aa7c2e37537202fc709869 | From | Paul Menage <> |
| |
On Wed, Aug 19, 2009 at 7:34 PM, Li Zefan<lizf@cn.fujitsu.com> wrote: > > It's sure that reverting this commit makes things easier, but > rebasing this patchset shouldn't be hard. And this doesn't > sound a good reason to revert an innocent commit. >
The problem is that Ben's patch set starts with a patch that adds the "procs" file, and then a patch that fixes the namespace bug, and he and you used different names for variables/functions even though you were doing essentially the same thing. So rebasing would involve pretty much entirely rewriting the first patch and ditching the second - not just a case of fixing up some merge conflicts.
Paul
| |