lkml.org 
[lkml]   [2009]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] Add rfkill support to compal-laptop
Johannes:

Johannes Berg wrote:
> Hi Mario,
>
> First, let me say I agree with Alan, the option 1 is more desirable if
> possible to do with the hardware. But this looks ok from an rfkill POV
> now, except there's a small bug:
>
>
It looks like option 1 works properly on my hardware, so I've switched
the other code around.
>
> That doesn't error out, so
>
>
>
> this will crash without NULL checks.
>
> (and you have to explicitly assign NULL in setup_rfkill() too, when
> bluetooth fails and wifi is freed)
>
>
OK, i've cleaned that up to just error out on the module if rfkill
doesn't get initialized right.
> johannes
>
I've resent separately, and think I have git send-email working, so
hopefully won't have to attach in the future.
--
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2009-08-19 20:41    [W:0.035 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site