lkml.org 
[lkml]   [2009]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/17] vfs: Remove sync_page_range_nolock
    On Wed, Aug 19, 2009 at 06:04:33PM +0200, Jan Kara wrote:
    > The last user of sync_page_range_nolock() is generic_file_aio_write_nolock().
    > Now we have converted all its callers to not hold i_mutex and so we can
    > afford to call sync_page_range() instead of sync_page_range_nolock() from
    > there. This non-necessarily acquires i_mutex when syncing block devices but
    > that's happening in fsync() path as well and block_fsync() may just drop +
    > reacquire i_mutex if we care enough.

    Looks good to me, but to stop people from using
    generic_file_aio_write_nolock accidentally I would rename it to
    blkdev_aio_write, move it to fs/block_dev.c and stop exporting it. That
    way any out of tree or in the merge queue filesystems is forced to use
    the appropinquate __generic_file_aio_write.



    \
     
     \ /
      Last update: 2009-08-19 18:23    [W:2.714 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site