Messages in this thread | | | Date | Wed, 19 Aug 2009 12:21:20 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 06/17] vfs: Remove sync_page_range_nolock |
| |
On Wed, Aug 19, 2009 at 06:04:33PM +0200, Jan Kara wrote: > The last user of sync_page_range_nolock() is generic_file_aio_write_nolock(). > Now we have converted all its callers to not hold i_mutex and so we can > afford to call sync_page_range() instead of sync_page_range_nolock() from > there. This non-necessarily acquires i_mutex when syncing block devices but > that's happening in fsync() path as well and block_fsync() may just drop + > reacquire i_mutex if we care enough.
Looks good to me, but to stop people from using generic_file_aio_write_nolock accidentally I would rename it to blkdev_aio_write, move it to fs/block_dev.c and stop exporting it. That way any out of tree or in the merge queue filesystems is forced to use the appropinquate __generic_file_aio_write.
| |