lkml.org 
[lkml]   [2009]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] acpi_power_meter: hwmon driver for ACPI 4.0 power meters
    On Mon, Aug 17, 2009 at 03:05:58PM -0700, Andrew Morton wrote:
    > > + if (ACPI_FAILURE(status)) {
    > > + ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PAI"));
    > > + return -EINVAL;
    > > + }
    > > +
    > > + if (data)
    > > + return -EINVAL;
    >
    > I find this test of `data' inexplicable. Is it just me, or do we need
    > a comment here?

    ACPI spec says that the _PAI method passes back 0 on success. I guess I'll
    reroll the patch with a comment stating that.

    > > + if (ACPI_FAILURE(status)) {
    > > + ACPI_EXCEPTION((AE_INFO, status, "Evaluating _SHL"));
    > > + return -EINVAL;
    > > + }
    > > +
    > > + if (data)
    > > + return -EINVAL;
    >
    > ditto.

    Ditto.

    --D


    \
     
     \ /
      Last update: 2009-08-18 18:27    [W:0.023 / U:0.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site